scitools.org.uk modernisation #182

LukeC92 · 2018-05-15T15:27:56Z

This pull request is not actually intended to be merged. This is to show the new version of the site created using mobirise, to allow others to preview it. The mobirise version can be found under
citools.org.uk/SciTools-Dev_2/export
The pages of relevance are index, organisation and privacy. They can be navigated around by opening index.html .

pelson · 2018-05-16T12:43:01Z

FWIW This can be seen at https://rawgit.com/LukeC92/scitools.org.uk/mobirise_version/SciTools-Dev_2/export/index.html.

pelson · 2018-05-16T13:44:45Z

LukeC92 · 2018-05-17T13:47:48Z

I'm making most of these changes in mobirise. I'll then copy these over and work on some of the others within a text editor.

Regarding the line "One of the primary objectives of this approach is to aid " In the original SciTools website this line appeared after mentioning that Iris and Cartopy are open source and published under and LGPLv3. For now I have simply swapped around the text order for clarity; we can look into further amendments later.

LukeC92 · 2018-05-17T14:34:36Z

The changes I just pushed address some, but not all, of the points @pelson made.

pelson · 2018-05-18T12:27:26Z

Once you're happy with getting these things in @LukeC92, I think the next step is to "de-mobrise" the pages - make sure they have a sensible folder structure, and that only the assets that are needed are included in the repository (currently there is quite a bit of gallery stuff in there still). After that, we can start to refine this in much more detail at the html level.

pelson · 2018-05-19T05:10:18Z

New link: https://rawgit.com/LukeC92/scitools.org.uk/mobirise_version/

pelson · 2018-05-19T05:43:31Z

I took a quick look at the CSS, and think the alignment and spacing of the navbar can be improved with:

diff --git a/static/mobirise/css/mbr-additional.css b/static/mobirise/css/mbr-additional.css
index 0c5fec2..5f21666 100644
--- a/static/mobirise/css/mbr-additional.css
+++ b/static/mobirise/css/mbr-additional.css
@@ -1391,10 +1391,10 @@ body {
   position: relative;
   text-decoration: none;
 }
.cid-qQ2bitRL25 .nav-item a {
   display: flex;
   align-items: center;
-  justify-content: center;
+  justify-content: left;
   padding: 0.7rem 0 !important;
   margin: 0rem .65rem !important;
 }
@@ -1468,9 +1468,13 @@ body {
   position: absolute;
   min-width: 5rem;
   padding-top: 1.4rem;
-  padding-bottom: 1.4rem;
+  padding-bottom: 0.5rem;
   text-align: left;
 }
+.dropdown-divider {
+    margin-left: 10%;
+    margin-right: 10%;
+}

…rise.

LukeC92 · 2018-05-24T12:52:26Z

@corinnebosley pointed out a link that no longer works within the sentence
"Publishing on a site such as GitHub, the SciTools Contributors approach and LGPLv3 license present one way of managing this."
For now I'll just remove the link to "collaboration-governance.html". However the sentence itself doesn't make sense to me. We probably need to read through a lot of the content to ensure clarity.

LukeC92 · 2018-05-25T20:14:11Z

I've added some changes to the text, based on the changes @kaedonkers suggested. However there are more changes to commit and I intend to make some comments about the existing text,

lbdreyer

Looking really good @LukeC92 ! This will be such a great improvement!

lbdreyer · 2018-05-29T10:43:52Z

index.html

+            <li>
+              <a href="https://github.com/SciTools/nc-time-axis"
+                  target="_blank"><strong>nc_time_axes</strong></a> - provides
+                  support for netcdftime axis in matplotlib. <a href=


Perhaps reword this to be "provides support for non-gregorian datetimes in matplotlib"

Fixed in #198.

lbdreyer · 2018-05-29T10:47:58Z

index.html

+            </li>
+            <li>
+              <a href="https://github.com/SciTools/nc-time-axis"
+                  target="_blank"><strong>nc_time_axes</strong></a> - provides


typo! This should be nc-time-axis

lbdreyer · 2018-05-29T10:48:31Z

index.html

+            </li>
+            <li>
+              <a href="https://github.com/SciTools/courses"
+                  target="_blank"><strong>scitools/courses</strong></a> -


It doesn't really make sense for this to be under the "Additional Tools" section. Although I do agree that it would be nice to be included on the homepage

Fixed in #198.

lbdreyer · 2018-05-29T10:50:27Z

organisation.html

+  </section>
+  <!-- END HEADER -->
+
+  <section class="header1 land-sea-image mbr-parallax-background">


This image seems a bit low res. I like the picture, but is there a way to get a higher resolution image?

lbdreyer · 2018-05-29T10:58:27Z

index.html

+            </a>
+            <a class="btn btn-md btn-primary display-4" href="index.html#cf_units">
+                <span class="mbri-watch mbr-iconfont mbr-iconfont-btn">
+                </span> cf_units


I misunderstood the purpose of these buttons. I see that they're more of a contents rather links other pages as I expected them to be. This does feel a bit unnatural
Regardless, I would remove cf_units as it isn't an individual section

lbdreyer · 2018-05-29T11:01:02Z

index.html

+                 create a data abstraction layer which isolates analysis and
+                 visualisation code from data format specifics. The data model
+                 we have chosen is the CF Data Model. The implementation of
+                 this model we have called an Iris Cube.<br>


These sentences are difficult to read and not as accessible as a summary should be, considering people may not familiar with these concepts
I will try to think of a way to reword this

Agree completely. I've wanted to do this too. I think whatever we write, we should also put in the iris README.md/rst too.

lbdreyer · 2018-05-29T11:02:56Z

index.html

+            </a>
+            <a class="btn btn-md btn-primary display-4" href="index.html#cf_units">
+                <span class="mbri-watch mbr-iconfont mbr-iconfont-btn">
+                </span> cf_units


For each page, these buttons are never on single line. Is it possible to make them be ona single line except (when they don't fit on the screen)

Fixed in #198.

pelson · 2018-05-29T13:35:38Z

Merged in 7469747.

Thanks for this fantastic piece of work @LukeC92.
I'm sure there are a lot of improvements we can continue to make to this, but let's do that iteratively, as we would for normal development (i.e. through small pull requests).

Thanks again @LukeC92!!! 🎉

Remove files no longer used since #182.

Add mobirise version.

5c62ed2

LukeC92 changed the title ~~Add example of mobirise site~~ Add example of mobirise version of site May 15, 2018

Carroll, Luke added 2 commits May 15, 2018 16:53

Edit head of index.

b8b0dd3

Restructure header.

ecabf33

Complete restructure of header.

1c7ba3c

Make some changes using mobirise.

cad576e

Carroll, Luke added 6 commits May 18, 2018 14:45

Restrutcutre the index header.

91d5edb

Improved the indentation of the pages.

5fe2778

Moved content into target location.

72311b6

Remove some obsolete files.

ed7c052

Added separator on GitHub dropdown

a535496

Update some pages including URL redirects.

dd2bd8b

pelson changed the title ~~Add example of mobirise version of site~~ scitools.org.uk modernisation May 21, 2018

Carroll, Luke added 9 commits May 21, 2018 16:23

Add separate Cartopy and cf_units buttons as well as tags.

3cc16d9

Gave the menu consistent class names.

dc6da2e

Edit 404 page to display an appropriate message.

96666de

Add some better tags to navigate around pages.

2619d81

Rename section tag and remove redundant tags.

aa731dc

Justified drop down menus to the left.

71a7572

Deleted some unused images and removed unnecessary references to mobi…

1279903

…rise.

Adjust links in footers.

9686d21

Added some meta data and removed some references to mobirise.

5c8152d

Carroll, Luke added 19 commits May 24, 2018 13:59

Change a link to GitHub to go to docs instead.

f1d535c

Ensure the 404 has spacing and a redirect.

bb62337

Add a build script that simplifies templating of standard html.

14372c8

Added a styles block to template CSS includes. More block needed later.

229ce56

Update build script to handle block indentation.

ec4b6fa

Add some better tags for navigation.

ab9c23b

Defined blocks and ran builder several times.

b0196be

Defined Meta block and ran build.

07ff909

Change Privacy Policy link.

f6c50f9

Add tags to SciTools link.

556b7cf

Improve layout of logo.

10311a3

Remove tags that aren't used.

c2fdc99

Rename bottom links tab.

fd24d27

Rename social links class.

6913a4d

Give several classes more useful names.

22c978e

Fixed cookies statement.

85eaa3e

Improved some layout.

790d84e

Gave some classes more useful names.

d3cf116

Made some changes to some of the text in organisation, more are to come.

9b097bc

pelson self-assigned this May 29, 2018

Fix nc_time_axes typo.

6d0335b

lbdreyer reviewed May 29, 2018

View reviewed changes

pelson closed this May 29, 2018

This was referenced May 29, 2018

Iris version switcher #191

Merged

Don't keep source and build product in the same repo #129

Closed

pelson added a commit to pelson/scitools.org.uk that referenced this pull request May 29, 2018

Remove files no longer used since SciTools#182.

fb51b40

pelson added a commit that referenced this pull request May 29, 2018

Merge pull request #192 from pelson/tidyup

737eed6

Remove files no longer used since #182.

pelson mentioned this pull request May 30, 2018

New site design review comments from @lbdreyer #196

Closed

scitools.org.uk modernisation #182

scitools.org.uk modernisation #182

Uh oh!

Conversation

LukeC92 commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelson commented May 16, 2018

Uh oh!

pelson commented May 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LukeC92 commented May 17, 2018

Uh oh!

LukeC92 commented May 17, 2018

Uh oh!

pelson commented May 18, 2018

Uh oh!

pelson commented May 19, 2018

Uh oh!

pelson commented May 19, 2018

Uh oh!

LukeC92 commented May 24, 2018

Uh oh!

LukeC92 commented May 25, 2018

Uh oh!

lbdreyer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pelson commented May 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LukeC92 commented May 15, 2018 •

edited

Loading

pelson commented May 16, 2018 •

edited

Loading