Prevent usage of floats as indices to numpy arrays due to deprecation #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling b457117 on djkirkham:iris-conda-forge-fixes into ** on SciTools:master**. |
Member
|
I don't think this is the right thing to do here. XRef SciTools/iris#2468. |
Member
|
Though I confess - I have no idea what the author was aiming for with the zeros use to determine the system float type (which can be got with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of numpy don't allow floats to be used as indices to arrays, even if they are integer-valued. This PR makes the tests pass (plus iris integration tests) with newer version of numpy, but I have not assessed other places in the code which may cause errors but are not caught by tests.