Import and run grib-dependent attribute handling tests from Iris. #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 8 8
Lines 2529 2529
Branches 415 415
=======================================
Hits 2274 2274
Misses 156 156
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Member
Author
|
Think this proves itself now, since SciTools/iris#6566 is merged, we now have an actual running (and passing) test example. |
trexfeathers
approved these changes
Jul 24, 2025
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @pp-mo, firstly for your diligence of making sure we test the concept, and secondly for working hard to establish a pattern that I hope we can 'play forward' to other areas of Iris-grib and in other satellite repos too.
src/iris_grib/tests/integration/iris_integration/test_nc_attribute_handlers.py
Show resolved
Hide resolved
Member
Author
|
Thanks @trexfeathers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. this will not function until SciTools/iris#6566 is merged,
since it uses the new tests provided there.
I think it should run once that is in, since we test against iris main branch.
Though we do also test against latest-release, and that will still fail until we update this...
TODO...
Made into draft as not currently viable...