Cosmetic change : rename the travis iris-test-version options #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
requested changes
Oct 12, 2020
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
I'm very much in favour of something less cumbersome than LIMIT_TO_RELEASED_IRIS, but I'm not a fan of VERSION, which already has another, different meaning. IRIS_SOURCE perhaps? Or something else if you can think of it.
trexfeathers
approved these changes
Oct 12, 2020
jamesp
added a commit
to jamesp/iris-grib
that referenced
this pull request
Feb 23, 2021
* upstream/v0.16.x: Docstest 0v16 (SciTools#244) Remove eccodes bug workaround added in SciTools#208. (SciTools#224) Update requirements to pick up Iris 3. (SciTools#243) Add 'main' conda-forge channel, needed for docs builds. (SciTools#240) Fix RC date in release notes (about to cut). (SciTools#235) Version 0.16 release candidate (SciTools#232) Cosmetic change : rename the travis iris-test-version options (SciTools#234) Travis test with both Iris latest-release and latest-master. (SciTools#231)
lbdreyer
pushed a commit
that referenced
this pull request
Feb 24, 2021
* Rename Iris test-version options, and enable all to check action. * Review changes.
bjlittle
pushed a commit
that referenced
this pull request
Mar 2, 2021
* Travis test with both Iris latest-release and latest-master. (#231) * Travis test with both Iris latest-release and latest-master. * Modify test CMLs for latest Iris (Iris3.0 changes). * Grib1 load fixes. * Fix loading since units=None default for Iris3 coords * Modify test to work with latest Iris (Iris3.0 changes). * Test against latest Iris only. * Review changes. * Cosmetic change : rename the travis iris-test-version options (#234) * Rename Iris test-version options, and enable all to check action. * Review changes. * Version 0.16 release candidate (#232) * Require Iris >=3 (just for the gdt90 changes). * Whatsnew entry for requiring Iris 3. * Set version string for release candidate. * Test against Iris 3.0.0rc0 from conda-forge/rc_iris. * Fix RC date in release notes (about to cut). (#235) * Add 'main' conda-forge channel, needed for docs builds. (#240) * Add 'main' conda-forge channel, needed for docs builds. * Use fixed spherical-earth-radius in GRIB1, ignoring change in gribapi default. * Codestyle fix. * Update requirements to pick up Iris 3. (#243) * Remove eccodes bug workaround added in #208. (#224) * Docstest 0v16 (#244) * Document PR#240 in release notes. * Fix version string and release-notes date. * Added getting started .cirrus.yml * Update cirrus to use miniconda image * Update .cirrus.yml * Update .cirrus.yml Copied across cirrus file from iris-ugrid * Added nox testing Borrowing from iris and iris-ugrid, added nox testing and a test runner. Tests currently fail on my local machine. * Path fixes in cirrus.yml * eccodes test added to noxfile * Added config and coverage * Trying to set SITE_CFG * syntax error * taking the IRIS_DIR from Travis CI config * Add allow_failures to the linux task for now * Dodgy r key... * Update .cirrus.yml * Allow failures in linting * Force return error 0 for now * Added eccodes test * moved matrix * Yaml syntax error & * wrong way around * Typo * Update iris version dependency * Date fix This resolves the same bash issue as SciTools/iris#4019 * Configure Iris in nox * Updated CI config * correct site-packages path * Fix to iris test data path * force cache update * refactored writing iris config in noxfile * Fix pep8 and license test fails * Support for testing against packaged iris and building from source * Adding yaml to list of cirrus container requirements * invalidate cirrus cache * really invalidate cirrus cache... * yaml -> pyyaml * missing iris_dir reference * call write_iris_config * docstrings and matrix testing * git syntax error * eccodes selfcheck in basic tests * Removed py3.8 testing for now * Fixed regression in setup.py test * Removed unused imports * Disabled lint checking * Removed nox from test dependencies for python3.6 and python3.8 * Removed python3.8 from noxfile * Removed nox from test requirements Co-authored-by: Patrick Peglar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Iris test-version options, and enable all to check action.
This will also demonstrate testing against latest release
-- but then some tests will fail
When we get to merge this F-B back, it is because we have an actual Iris 3.0 release.
In that case, this should start to work.