Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 30, 2025

Addresses problems with #6752

Hopefully ...

@pp-mo pp-mo marked this pull request as ready for review October 30, 2025 12:29
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (e31fdec) to head (b1d0478).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6773   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files          91       91           
  Lines       24720    24728    +8     
  Branches     4632     4634    +2     
=======================================
+ Hits        22337    22345    +8     
  Misses       1610     1610           
  Partials      773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo, see the above comments.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! And we definitely need a What's New entry, together with our intent to remove the pins as soon as we can.

scitools-ci[bot]
scitools-ci bot previously requested changes Oct 30, 2025
Copy link
Contributor

@scitools-ci scitools-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! Thanks again

@trexfeathers trexfeathers enabled auto-merge (squash) October 30, 2025 16:08
@trexfeathers trexfeathers disabled auto-merge October 30, 2025 16:12
@trexfeathers
Copy link
Contributor

ERROR: Package 'scitools-iris' requires a different Python: 3.14.0 not in '<3.14,>=3.11'

Pause GIF I Approve Of This Message GIFs _ Tenor

@trexfeathers trexfeathers merged commit 2adb411 into SciTools:main Oct 30, 2025
22 checks passed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 28, 2025
@pp-mo pp-mo deleted the v3x14_pins branch November 29, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants