Skip to content

Updated example to work with newer sample data. #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bblay merged 3 commits into from
Jun 27, 2013
Merged

Updated example to work with newer sample data. #570

bblay merged 3 commits into from
Jun 27, 2013

Conversation

@pelson
Copy link
Member

@pelson pelson commented Jun 21, 2013

This change depends on SciTools/iris-sample-data#2 being accepted.

@ghost ghost assigned bblay Jun 24, 2013
@bblay
Copy link
Contributor

bblay commented Jun 24, 2013

The graphic has changed; there are about 30 times as many x ticks and all the x labels overlap.
The rest of the graph is exactly the same though.

@bblay
Copy link
Contributor

bblay commented Jun 24, 2013

The extests also fail as a result of the changed graphic.

@pelson
Copy link
Member Author

pelson commented Jun 24, 2013

The extests also fail

They passed for me... strange. Wont be able to test this now for a couple of weeks. Can you double check that it has broken it with the new data?

@bblay
Copy link
Contributor

bblay commented Jun 25, 2013

Can you double check

Apologies, that built fine. Not sure what I did wrong there.

I'm now getting 3 doctest failures though, related to an extra forecast_reference_time coord.
Can you confirm or did I do that wrong too? 😀

@pelson
Copy link
Member Author

pelson commented Jun 25, 2013

Can you confirm or did I do that wrong too?

Ah no. I probably didn't run those. Are you able to help me out by providing fixes? If not, I'll do it when I get back.

Thanks,

@bblay
Copy link
Contributor

bblay commented Jun 26, 2013

Aye, pelson#15

bblay added a commit that referenced this pull request Jun 27, 2013
@bblay
Merge pull request #570 from pelson/new_sample_data_update
9642173 
Updated example to work with newer sample data.
@bblay bblay merged commit 9642173 into SciTools:master Jun 27, 2013
@pp-mo pp-mo mentioned this pull request Jun 28, 2013
Closed
@cpelley cpelley mentioned this pull request Jul 1, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bblay bblay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pelson @bblay