Skip to content

Conversation

@bjlittle
Copy link
Member

🚀 Pull Request

Description

This pull-request explicitly sets the line-length = 88 (instead of 79) for black, ruff and isort.

This brings iris into alignment with the default line-length recommended by black.


Consult Iris pull request check list

@bjlittle
Copy link
Member Author

@tkknight This change should help with your pydocstyle efforts, giving us a wee bit more real-estate for docstrings 👍

@codecov
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (dcff29d) 89.69% compared to head (37004ff) 89.69%.

Files Patch % Lines
lib/iris/aux_factory.py 52.83% 25 Missing ⚠️
lib/iris/experimental/raster.py 0.00% 6 Missing ⚠️
lib/iris/analysis/_regrid.py 58.33% 5 Missing ⚠️
lib/iris/coords.py 78.26% 5 Missing ⚠️
lib/iris/cube.py 90.74% 5 Missing ⚠️
lib/iris/experimental/ugrid/mesh.py 89.18% 4 Missing ⚠️
lib/iris/_concatenate.py 83.33% 3 Missing ⚠️
lib/iris/analysis/__init__.py 86.95% 3 Missing ⚠️
lib/iris/analysis/_scipy_interpolate.py 40.00% 3 Missing ⚠️
lib/iris/fileformats/netcdf/saver.py 92.10% 2 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5632   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight merged commit 0cdead6 into SciTools:main Dec 13, 2023
tkknight added a commit to tkknight/iris that referenced this pull request Dec 13, 2023
* upstream/main:
  Replace isort with ruff (SciTools#5633)
  Line length 88 (SciTools#5632)
@bjlittle bjlittle deleted the line-length-88 branch December 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants