Update standard-names to #82 + add table version in std_names.py #5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ping @HGWright can you take this on ?? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5423 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 89 89
Lines 22443 22443
Branches 5381 5381
=======================================
Hits 20058 20058
Misses 1639 1639
Partials 746 746 ☔ View full report in Codecov by Sentry. |
pp-mo
force-pushed
the
stdnames_update
branch
3 times, most recently
from
a154db7 to
c69d28e
Compare
HGWright
approved these changes
Aug 16, 2023
Contributor
HGWright
left a comment
HGWright
left a comment
There was a problem hiding this comment.
We believe the RTD failiure is a one off and we can't run again off of this PR. We are going to merge and make sure this it works on the next PR before the 3.7 release.
HGWright
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the standard-names table to latest version 82
Also, since it was one of the requests in #5255, I have added a little piece of code to include the table version in the file header + provide it as a public global variable.
(and a silly little test for that)