Remove test timings #5101
Merged
Remove test timings #5101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
requested changes
Dec 14, 2022
Member
lbdreyer
left a comment
lbdreyer
left a comment
There was a problem hiding this comment.
Looking great! Thanks for doing this @rcomer !
I spotted one other mention of IrisTest_nometa here: https://github.com/SciTools/iris/blame/main/lib/iris/tests/graphics/README.md#L27
Do you mind also updating that in this PR?
rcomer
force-pushed
the
remove-test-timings
branch
from
05705ec to
d3ad08c
Compare
Member
Author
|
Thanks @lbdreyer, good spot! I only grepped the python files. Now fixed and also rebased to address the whatsnew conflict. |
lbdreyer
approved these changes
Dec 14, 2022
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 5, 2023
* upstream/main: (167 commits) pip pin for sphinx<5 (SciTools#5122) [pre-commit.ci] pre-commit autoupdate (SciTools#5120) Bump actions/stale from 6 to 7 (SciTools#5117) [pre-commit.ci] pre-commit autoupdate (SciTools#5114) Correct heading for v3.4 release highlights. (SciTools#5110) Announce @ESadek-MO as a core Iris developer. (SciTools#5111) Remove test timings (SciTools#5101) Switch order of options and parameter in `ncgen` command (SciTools#5105) [pre-commit.ci] pre-commit autoupdate (SciTools#5107) Updated environment lockfiles (SciTools#5104) DOC: improve gallery test instructions (SciTools#5100) Updated environment lockfiles (SciTools#5092) Update What's New for 3.4 release. (SciTools#5088) [pre-commit.ci] pre-commit autoupdate (SciTools#5086) Updated environment lockfiles (SciTools#5085) Updated environment lockfiles (SciTools#5080) Restore latest What's New files. Documentation updates for `v3.4.0rc0` release. (SciTools#5078) What's New fixes. (SciTools#5077) More accurate netcdf4 pin `<1.6.1`. (SciTools#5075) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Here is some more Iris functionality that I did not know existed, until @pp-mo mentioned it the other day. Described by the removed comment
iris/lib/iris/tests/__init__.py
Lines 940 to 946 in 6eb0401
I tried to run this with
unittest discoveras the comment recommends, but got errors, particularly from test_pandas.py. I found that this functionality can be used withpytest -s -v, so if we do want to keep the functionality we should probably document that. I'm unsure if it can be made to work withpytest-xdist.In any case, pytest provides its own functionality to tell you the timings of the slowest running tests via the
--durationsflag, and of course we now have somepytesttests which don't inherit fromIrisTest, so won't work with the bespoke functionality unless we go through and add the decorator.More generally, the more we can simplify these test classes, the better chance we have of eventually ditching
unittestaltogether.This functionality was added at #2372.
Consult Iris pull request check list