Update the iris.experimental module
#5056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bjlittle
requested changes
Nov 11, 2022
Member
bjlittle
left a comment
bjlittle
left a comment
There was a problem hiding this comment.
@trexfeathers Thanks, a lovely piece of housekeeping 🥳
Just a minor comment to address regarding the choice of exception to raise.
Also, the benchmark GHA makes reference to IRIS_TEST_DATA_VERSION: "2.15"... did you want to update that also?
bjlittle
approved these changes
Nov 11, 2022
Contributor
Author
|
All kinds of done! Thanks again 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Standard 'spring cleaning' to make sure the contents of
iris.experimentalbelong there (see #3515 (comment)).Requires SciTools/iris-test-data#83.
Closes #3515.
(For moving something out of
iris.experimental, I copied the style in #3390).Consult Iris pull request check list