Changes for Matplotlib v3.5 #4428
Conversation
|
See #4424 for failing tests. |
github-actions
bot
force-pushed
the
auto-update-lockfiles
branch
from
774f9cf to
a1dfa9b
Compare
|
The replaced commit on the Do we know if it's possible for the lockfile action to add a new commit to the branch rather than replace the existing commit? That would make this a little more straightforward I think. Probably a question for @jamesp. |
|
I think that we included some logic in the GHA to stop the bot from clobbering any additional commits already on the auto-update-lockfiles branch, but not for the workflow you're describing @rcomer. The workflow creates/updates the PR using this action: https://github.com/peter-evans/create-pull-request It might be somewhere in the options but I can't recognise it from the descriptions given. We did also consider making a new PR for each run of the action - that would prevent this situation, but possibly result in a profusion of lockfile update PRs if we don't get to merging in each week. |
|
Thanks for looking @jamesp. At least the new commit didn’t introduce new failures! |
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Looks good, especially the switch to mocking - big improvement. I have re-spun the failed tests to prove that the failed image test should be fine now.
|
Thanks @trexfeathers! |
* Updated environment lockfiles * Changes for Matplotlib v3.5 (#4428) * add new image hash for gallery example * update antialias tests * whatsnew Co-authored-by: Lockfile bot <[email protected]> Co-authored-by: Ruth Comer <[email protected]>
3 participants
🚀 Pull Request
Description
Changes to get tests passing with Matplotlib v3.5.
plt.contourhas been called, in addition toplt.contourf. The tests previously relied on the fact that the two functions added different artist types to the axes, but this is no longer the case (3.5.0b1: ax.contour generates different artists matplotlib/matplotlib#20906). So have updated these tests to usemockinstead.Consult Iris pull request check list