Removed addition of period from wrap_lons #4421
Conversation
|
Assuming the tests run for this PR, do let me know if you want me to edit the |
wjbenfold
left a comment
wjbenfold
left a comment
There was a problem hiding this comment.
Still looks good, just like the identical PR did. Having checked the values that came out of this fix, it actually improved the precision of the test result. The tests are now doing a more sane check on the floating point values.
Do please update latest.rst to name the right PR, just to avoid confusing anyone
Updated affected tests using assertArrayAllClose following SciTools#3993.
akuhnregnier
force-pushed
the
new-factor-two
branch
from
7c02456 to
f4e5e99
Compare
wjbenfold
left a comment
wjbenfold
left a comment
There was a problem hiding this comment.
Looks good to me. Something slightly odd where it thinks line 120 of the whatsnew has just appeared, but that's probably from force pushing rather than pushing in some way. Will just check that as it gets merged.
* main: (23 commits) Suggest type hinting (SciTools#4390) area weight regrid test fixes (SciTools#4432) Update latest.rst (SciTools#4425) Added @wjbenfold to the core dev list (SciTools#4423) Removed addition of period from wrap_lons. (SciTools#4421) Add release docs sections describing the role of a Release Manager (SciTools#4413) Subset should always return None if no value matches are found (SciTools#4417) What's new for SciTools#4400 (SciTools#4422) `iris.analysis.AreaWeighted` regrid speedup (SciTools#4400) [pre-commit.ci] pre-commit autoupdate (SciTools#4419) Remove newline to satisfy setuptools (SciTools#4418) Updated environment lockfiles (SciTools#4416) NAME loader fixes (SciTools#4411) Updated whatsnew for PR 4402 (SciTools#4410) Support test data in benchmark workflows (SciTools#4402) What's new for pr 4387 (SciTools#4405) Make concat mismatch warning for scalar coords more accurate (SciTools#4387) Added line to latest release notes for updates to pp_save_rules.py (SciTools#4404) Update pp_save_rules.py (SciTools#4391) [pre-commit.ci] pre-commit autoupdate (SciTools#4403) ...
3 participants
Updated affected tests using assertArrayAllClose following #3993.
🚀 Pull Request
Description
Please see #3994.