Remove iris.experimental.concatenate module #3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
abooton
reviewed
Nov 15, 2019
| @@ -0,0 +1,3 @@ | |||
| * The :mod:`iris.experimental.concatenate` module has now been removed. Previously the experimental `concatenate` | |||
| functionality was moved to the :meth:`iris.cube.CubeList.concatenate` method as of v1.6.0, and calling the | |||
| :func:`iris.experimental.concatenate.concatenate` function raised an exception. | |||
Contributor
There was a problem hiding this comment.
Maybe slightly clearer - but is fine really:
- The :mod:
iris.experimental.concatenatemodule has now been removed. In v1.6.0 the experimentalconcatenate
functionality was moved to the :meth:iris.cube.CubeList.concatenatemethod. Calling the :func:iris.experimental.concatenate.concatenatefunction has raised an exception since then.
Member
Author
There was a problem hiding this comment.
@abooton I've made a further minor tweak to your excellent revision. Seems reasonable, take a peek...
Member
Author
|
@abooton Awesome, thanks again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the now defunct
iris.experimental.concatenatemodule.Reference #3515