-
Notifications
You must be signed in to change notification settings - Fork 300
Improve repr_html coverage #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rebase onto source
| 'Auxiliary coordinates:': None, | ||
| 'Derived coordinates:': None, | ||
| 'Cell Measures:': None, | ||
| 'Ancillary Datasets:': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been throwing around a few different names for this (Ancillary Data, Ancillary Dataset, Ancillary Variable), so I think that's where some of the confusion has come from, but have agreed to call these Ancillary Variables so this will need updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ancillary Datasets is what is currently being written in the summary here
Line 2206 in 77e4b3f
| summary += '\n Ancillary Datasets:\n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot! That does need changing!
I had originally called in "Ancillary Datasets" but that was pushed back so I needed to rename everything and clearly missed that name change!
bjlittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenworsley I think that we're going to need some further test coverage of Cell measures, Ancillary variables, Invalid coordinates and Scalar cell measures.
Would you mind doing the honours?
3ee861b to
360b0d6
Compare
lib/iris/tests/unit/experimental/representation/test_CubeRepresentation.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/representation/test_CubeRepresentation.py
Outdated
Show resolved
Hide resolved
6836af5 to
f981869
Compare
f981869 to
39d98e8
Compare
|
LGTM Thanks @stephenworsley 👍 |
Addresses some of the comments made in #3467 . repr_html should work better in a few more cases now (recognising more headers, handling headers which aren't formatted with a colon etc.).