Skip to content

Conversation

@stephenworsley
Copy link
Contributor

Addresses some of the comments made in #3467 . repr_html should work better in a few more cases now (recognising more headers, handling headers which aren't formatted with a colon etc.).

@lbdreyer lbdreyer added this to the v3.0.0 milestone Oct 22, 2019
'Auxiliary coordinates:': None,
'Derived coordinates:': None,
'Cell Measures:': None,
'Ancillary Datasets:': None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been throwing around a few different names for this (Ancillary Data, Ancillary Dataset, Ancillary Variable), so I think that's where some of the confusion has come from, but have agreed to call these Ancillary Variables so this will need updating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ancillary Datasets is what is currently being written in the summary here

summary += '\n Ancillary Datasets:\n'
. Should I take it that this ought to be changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! That does need changing!
I had originally called in "Ancillary Datasets" but that was pushed back so I needed to rename everything and clearly missed that name change!

@bjlittle bjlittle self-assigned this Oct 30, 2019
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephenworsley I think that we're going to need some further test coverage of Cell measures, Ancillary variables, Invalid coordinates and Scalar cell measures.

Would you mind doing the honours?

@stephenworsley
Copy link
Contributor Author

Due to #3496 it may well be impossible to test Invalid coordinates. I think I'll probably remove Invalid coordinates from str_headings until #3496 is resolved.

@stephenworsley stephenworsley force-pushed the repr_coverage branch 3 times, most recently from 6836af5 to f981869 Compare November 1, 2019 09:39
@bjlittle
Copy link
Member

bjlittle commented Nov 1, 2019

LGTM Thanks @stephenworsley 👍

@bjlittle bjlittle merged commit 66423f8 into SciTools:master Nov 1, 2019
bjlittle added a commit to bjlittle/iris that referenced this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants