Skip to content

Revert "test_pearsonr: use compatible cubes for testing compatible cubes" #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pelson wants to merge 2 commits into from
Closed

Revert "test_pearsonr: use compatible cubes for testing compatible cubes" #3004

pelson wants to merge 2 commits into from

Conversation

@pelson
Copy link
Member

@pelson pelson commented May 1, 2018

Reverts #2960

CC @pp-mo

@pelson pelson requested a review from pp-mo May 1, 2018 09:15
This was referenced May 1, 2018
Merged
Closed
@pp-mo
Copy link
Member

pp-mo commented May 1, 2018 •
edited
Loading

Problem with license header.
We could just merge this + wait for re-introduction of #2960.
Maybe it's better to just get on though.

Proposed alternative PR : #3005 extends this, should check out ok ...

@rcomer
Copy link
Member

rcomer commented May 1, 2018 •
edited
Loading

I believe I've fixed this and will submit a new PR just as soon as I remember the right combination of git commands(!)

Edit: new PR now at #3006

@pelson
Copy link
Member Author

pelson commented May 1, 2018

Replaced by #3006.

@pelson pelson closed this May 1, 2018
@pelson pelson deleted the revert-2960-pearsonr-test-compatible branch May 1, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pp-mo pp-mo Awaiting requested review from pp-mo

Assignees

@pp-mo pp-mo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pelson @pp-mo @rcomer @QuLogic