Skip to content

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 1, 2024

🚀 Pull Request

Description

This PR adapts the code for numpy 2.0. I'm building on top of #313 b/c this one should be merged after that one.
Note that I did not add numpy 2.0 to the test matrix yet. The test matrix here is quite complex with automated conda-lock, tox, etc. It is quite hard to contribute to it!

@pp-mo
Copy link
Member

pp-mo commented Sep 12, 2024

NOTE: This might couple to #443
Not sure of the exact relationship here, needs investigating

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 13, 2024

NOTE: This might couple to #443 Not sure of the exact relationship here, needs investigating

Note that PyPI doesn't support repodata patching, like in conda-forge. That means cf-units build with numpy<2 will be installable in numpy>=2 envs unless the user pins it! Changes like https://github.com/SciTools/cf-units/pull/427/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 would help ameliorate that if a new release with these changes are out soon. Another action would be a post release of the current one with the numpy<2 pin in it.

@pp-mo
Copy link
Member

pp-mo commented Sep 27, 2024

Now replaced by #488.
Sorry if this stole some of your changes.

Note that PyPI doesn't support repodata patching

Useful to know. Following the current flurry of changes, we intend to make a new release soon, including this.
So hopefully that will fix most dependency problems thereafter.

@pp-mo pp-mo closed this Sep 27, 2024
@ocefpaf ocefpaf deleted the numpy_2_testing branch September 28, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants