Skip to content

Conversation

@rcomer
Copy link
Member

@rcomer rcomer commented Jan 6, 2023

🚀 Pull Request

Description

Pytest was throwing a warning because it ran this method as a test, and tests shouldn't return anything. Changing the name ensures pytest doesn't think it's a test.

Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcomer ! Good to get this fixed since the pytest warning states that it will become a error in future pytest versions

@lbdreyer lbdreyer merged commit fedca42 into SciTools:main Jan 6, 2023
@rcomer rcomer deleted the fix-setup-method branch January 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants