infrastructure refresh #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
added
Type: Infrastructure
Type: Enhancement
New: Pull Request
Collaborator
|
If no-one has looked at this by Monday I will carve out some time. |
ocefpaf
previously approved these changes
Mar 11, 2022
trexfeathers
requested changes
Mar 16, 2022
Collaborator
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
That was a tough review!
Thanks for the effort @bjlittle - a big improvement. Got some comments for you.
(@bjlittle and I suspect that having setuptools in the dependencies YAML means that the other setup dependencies (specified in pyproject.toml) will all get picked up automatically. If not, we will find out when RTD fails!)
Co-authored-by: Martin Yeo <[email protected]>
Co-authored-by: Martin Yeo <[email protected]>
Co-authored-by: Martin Yeo <[email protected]>
Co-authored-by: Martin Yeo <[email protected]>
trexfeathers
approved these changes
Mar 31, 2022
Collaborator
|
Beautiful @bjlittle! And the PR's not bad either 😁 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR shows some love to the
cf-unitsinfra-structure.In a nutshell:
cirrus-ciwith GHAdependabottoxconda-lockexplicit environment spec fileslinux,osxandwindowslockssdistandbdistbuilding/testing/publishing and replaced with thecibuildwheelGHAreadthedocsto usemambafor faster buildingsetuptools-scm-git-archivepluginoldest-supported-numpymeta packagepy310(replaces/incorporates Fix py310 test #207)py38docdirectory to thedocsdirectoryPost merge, suggested follow-on tasks to consider would be to:
ci-wheelsto build forosxandwindowsusingcibuildwheel, andcompositeactions.This ones for you @ocefpaf 🍻 😉