-
Notifications
You must be signed in to change notification settings - Fork 49
Build and publish Wheels #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 6 6
Lines 819 819
Branches 103 103
=======================================
Hits 745 745
Misses 62 62
Partials 12 12 Continue to review full report at Codecov.
|
|
@ocefpaf I was about to crank out the |
|
@bjlittle I'm not going to work on Windows and macOS at the moment b/c those require some extra knowledge and time that I don't have. (Installing udunits2 in those systems, finding the right paths, etc.) This is almost ready but there is a problem with the TL;DR I'm not going to dig into this b/c code changes here would imply extra tests and adaptations to avoid breakages. Do you have any insights on how to solve this? |
|
@ocefpaf Test away my man... ping me when you think this PR is good to go. Take it out of draft and I'll re-review again... it's mighty close now 🍻 |
| uses: pypa/gh-action-pypi-publish@master | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_PASSWORD }} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an API token on PyPI for a generic scitools-pypi user that we have, and also created the associated cf-units GitHub repository secret PYPI_PASSWORD
| python -m twine check * | ||
|
|
||
| - name: Publish a Python distribution to PyPI | ||
| uses: pypa/gh-action-pypi-publish@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bjlittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, let's go for it @ocefpaf 🚀
I'll create a follow-up PR to pin the action release version used 👍


Nothing to see here for now. Just testing...