Type preservation #164
Merged
Type preservation #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
reviewed
Mar 9, 2021
trexfeathers
requested changes
Jun 15, 2021
Collaborator
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks so much for your contribution @znicholls! And sorry for letting this go stale.
Please could you rebase, and service my suggestion for making the code more generic?
znicholls
force-pushed
the
163-type-preservation
branch
from
d67e9a7 to
c1d0279
Compare
stickler-ci
reviewed
Jun 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 90.48% 90.61% +0.13%
==========================================
Files 7 7
Lines 830 831 +1
Branches 105 105
==========================================
+ Hits 751 753 +2
Misses 64 64
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
Contributor
Author
No worries, lots happening
Done |
trexfeathers
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163