Numpy setup.py fixes#153
Merged
bjlittle merged 2 commits intoSciTools:masterfrom Jul 24, 2019
aodn:numpy-setup-fix
Merged
Conversation
1 similar comment
bjlittle
reviewed
Jul 23, 2019
added 2 commits
July 24, 2019 16:55
… Python 2 until support officially dropped
Member
|
@lwgordonimos Awesome, thanks 👍 |
ghost
deleted the
Author
|
No worries, makes perfect sense to keep it contained. Sorry, I glanced at your example and jumped the gun with copy/pasting without noting the details! |
Member
|
@lwgordonimos Cool, thanks for the PR, much appreciated! 🍻 I've already tagged the patch release Nice one, all the best! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've provided some examples of how I was able to fix the couple of issues (#151 and #152) I recently raised in this repo.
Feel free to pick them apart or use as-is, or suggest changes!