Fixes issue #144.#145
Merged
pelson merged 2 commits intoSciTools:masterfrom Feb 2, 2019
mrshannon:fix_issue_144
Merged
Conversation
As per the method documented by ead at https://stackoverflow.com/a/54138355 this delays the numpy.get_include() call until after after the packages listed in setup_requires are installed.
stickler-ci
reviewed
Feb 1, 2019
Member
|
👍 Thanks @mrshannon for persisting 😄 LGTM, thoughts @pelson ? |
Member
|
Super. thanks @mrshannon. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #144 as per the method documented by ead at https://stackoverflow.com/a/54138355. This delays the
numpy.get_include()call until after the packages listed insetup_requiresare installed.Removes the need to manually run:
before installing
cf-units.I have tested this for: