fix: resolve integration test failures on Linux#981
Merged
Conversation
- Change post-increment to pre-increment in run_tests.sh to fix bash arithmetic issue with `set -e` (PASS_COUNT++ returns exit code 1 when counter is 0) - Add cleanup section to db.ez to remove test database files after tests complete, preventing failures on consecutive runs Fixes #978 Co-Authored-By: UiJong (Jace), Yang <[email protected]>
SchoolyB
added a commit
that referenced
this pull request
Apr 3, 2026
- Change post-increment to pre-increment in run_tests.sh to fix bash arithmetic issue with `set -e` (PASS_COUNT++ returns exit code 1 when counter is 0) - Add cleanup section to db.ez to remove test database files after tests complete, preventing failures on consecutive runs Fixes #978 Co-authored-by: UiJong (Jace), Yang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #978 - Integration tests fail on Linux due to two issues:
Bash arithmetic with
set -e: Post-increment((PASS_COUNT++))returns exit code 1 when the counter is 0, causing the script to terminate immediately after the first passing test.Leftover
.ezdbfiles: Thedb.eztest creates database files that persist between runs, causingdb.keys()to find unexpected keys on subsequent runs.Changes
integration-tests/run_tests.sh((PASS_COUNT++))to((++PASS_COUNT))((FAIL_COUNT++))to((++FAIL_COUNT))integration-tests/pass/stdlib/db.ez@ioto importsmydb.ezdbrename_test.ezdbsort_test.ezdbTest Results
db.ezpasses on consecutive runs.ezdbfiles after test completion