fix: Typechecker modification to resolve "using directive" bug#979
Merged
SchoolyB merged 13 commits intoSchoolyB:mainfrom Jan 10, 2026
Merged
fix: Typechecker modification to resolve "using directive" bug#979SchoolyB merged 13 commits intoSchoolyB:mainfrom
SchoolyB merged 13 commits intoSchoolyB:mainfrom
Conversation
Scanf-s
changed the title
SchoolyB
pushed a commit
that referenced
this pull request
Apr 3, 2026
* feat(http): add HTTP status code constants * fix: Add IsConstant checker to all constants in stdlibs * fix: add stdlib.math constants type checker with unit test codes * fix: add stdlib.db constants type checker with unit test code * fix: add stdlib.http constants type checker with unit test code * chore: rename unit test functions name * fix: add stdlib.io constants type checker with unit test code * fix: add stdlib.time, stdlib.uuid constants type checker with unit test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #909 - The using directive now correctly brings stdlib module constants into scope, not just functions. Previously, constants like http.OK or os.MAC_OS required the full module prefix even after declaring using http or using os.
Changes
Typecheker
isStdlibConstant()function that maps module names to their exported constantsisKnownIdentifier()to recognize stdlib constants accessible via using directivesStdlib
IsConstantSome unit tests
Added typechecker tests for constants from all affected modules
Test Results
Unit tests
All passed 👍
Integration tests
All passed individually, but please check this issue #978