Added json output of equalizer information of the device#358
Merged
Sapd merged 2 commits intoSapd:masterfrom Jul 22, 2024
nicola02nb:master
Merged
Added json output of equalizer information of the device#358Sapd merged 2 commits intoSapd:masterfrom nicola02nb:master
Sapd merged 2 commits intoSapd:masterfrom
nicola02nb:master
Conversation
Contributor
Author
|
Just seen I've broken the --equalizer feature |
Contributor
Author
|
@Sapd I think that the |
Owner
|
Yep dont worry about the whitespace error. I will check the PR on the weekend |
Contributor
Author
|
Yeah, no problem, it was olny a suggetsion :) |
…c nova 7 plus Fix a crash caused by get_float_data_from_parameter() function and added allocatioo and deallocation for equalizer bands_values Added Bands step for equalizer info; changed equlalizer preset values type; added equalizer info and refactor in steelseries_artic_nova_7.c Added equalizer and equalizer preset output json info
utility: Make get_byte_data behave the same way Add equalizer info also as JSON
Owner
|
Thank you! sorry for the delay. I also added YAML output |
Contributor
Author
|
No worries, thanks for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made
EqualizerInfoandEqualizerPresetandEqualizerPresetsstructsEqualizerInfoandEqualizerPresetandEqualizerPresetsstructs todevicestructjsonoutput forEqualizerPresetandEqualizerPresetssteelseries_arctis_nova_7.cfor adding support of the new info to outputChecklist