Added capabilities for Artic Nova 7 mirophone(tested and working) and…#356
Added capabilities for Artic Nova 7 mirophone(tested and working) and…#356Sapd merged 2 commits intoSapd:masterfrom nicola02nb:missing-fatures-artic-nova-7
Conversation
|
I will do a The other commented out functions dont work at all? |
src/device.c
Outdated
| [CAP_VOLUME_LIMITER] = 'g'//, | ||
| //[CAP_BT_WHEN_POWERED_ON] = 'h', | ||
| //[CAP_BT_CALL_VOLUME] = 'c' |
There was a problem hiding this comment.
The capabilities_str_short is basically used for the deprecated short output future.
I think I will replace it with \0 for the new features, and add a check here
Line 728 in f64ac48
There was a problem hiding this comment.
The
capabilities_str_shortis basically used for the deprecated short output future.I think I will replace it with \0 for the new features, and add a check here
Line 728 in f64ac48
that it does not output something on \0
There I've putted some random letters as a placeholder... if you want to remove them after my edits, you're free to do it.
Oh cool, I will totally check it. I tried the other functions, but they were not working... I try to see if they are an easy fix, but I haven't any experience on wireshark... may |
|
I also forgot to put the help section for the new command... |
|
Updated the branch with new working features... I didn't got |
|
Can you explain me line 32 of the code style ceck? |
Yeah there is a whitespace at the end of the line But does not really matter, I will also fix the enum from above later and then also re run a format over it |
Oh 😅 |
|
Any info on first error? |
|
Looks fine to me. I think the whitespace check is quite simple and just does a diff to the commit before. It just sees that there is a diff and that its why it outputs it. It will probably go away when I merge it later. |
|
Ok, I hope I wasn't an issue with all this commits 😅 |
New device features: - volume limiter - bluetooth when powered on - bluetooth call volume
- Update README with new features - Don't add short output info for new features - Remove double option - Increase API version
|
Thank you! well done |
2 participants
… volume limiter(tested and working); pre inserted instruction for bluetooth capabilities(tested,not working)
Changes made
Added features for
Steelseries Artic Nova 7:Pre added instructions to
main.c,device.handdevice.cfor possible future implementation of:Checklist