Skip to content

Comments

Add Arctis Nova 3 support#319

Merged
Sapd merged 3 commits intoSapd:masterfrom
AnErrupTion:arctis-nova-3
Dec 27, 2023
Merged

Add Arctis Nova 3 support#319
Sapd merged 3 commits intoSapd:masterfrom
AnErrupTion:arctis-nova-3

Conversation

@AnErrupTion
Copy link
Contributor

@AnErrupTion AnErrupTion commented Dec 27, 2023

Hello! This PR adds support for the Arctis Nova 3 headset. Alongside this, it adds 2 new capabilities that this headset implements, those being the following:

  • CAP_MICROPHONE_MUTE_LED_BRIGHTNESS
  • CAP_MICROPHONE_VOLUME

The headset also implements the following existing capabilities:

  • CAP_SIDETONE
  • CAP_EQUALIZER_PRESET
  • CAP_EQUALIZER

Closes #294.

@AnErrupTion
Add Arctis Nova 3 support
86e3a3f 
Signed-off-by: AnErrupTion <[email protected]>
@Sapd
Copy link
Owner

Sapd commented Dec 27, 2023 •
edited
Loading

Thank you!

-o probably has to be replaced with some other letter. As it will be used for output for a further release.
Also I think you forgot to map the long names like --microphone-volume into struct option opts[] = {
We could think about for the new functions, to maybe only map a long name and no short letter at all (can be done by leaving out the letter in getopt_long and implementing the function at case 0:; like done for --timeout)

@AnErrupTion
Fix code style
50af1f3 
Signed-off-by: AnErrupTion <[email protected]>
@AnErrupTion
Copy link
Contributor Author

AnErrupTion commented Dec 27, 2023

Also I think you forgot to map the long names like --microphone-volume into struct option opts[] = {

Yup, haha! Good catch!

We could think about for the new functions, to maybe only map a long name and no short letter at all

That to me sounds like a better bet.

@Sapd Sapd merged commit 5b9ed65 into Sapd:master Dec 27, 2023
@AnErrupTion AnErrupTion deleted the arctis-nova-3 branch December 27, 2023 17:51
rpbaptist pushed a commit to rpbaptist/HeadsetControl that referenced this pull request May 31, 2024
@AnErrupTion
Add Arctis Nova 3 support (Sapd#319)
7a40319 
* Add Arctis Nova 3 support

Signed-off-by: AnErrupTion <[email protected]>

* Fix code style

Signed-off-by: AnErrupTion <[email protected]>

* Don't use short letters for new capabilities

Signed-off-by: AnErrupTion <[email protected]>

---------

Signed-off-by: AnErrupTion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SteelSeries Arctis Nova 3 support

2 participants

@AnErrupTion @Sapd