Moving battery calculation for lipo discharge into utility.c#227
Merged
Sapd merged 3 commits intoSapd:masterfrom Aug 17, 2022
Merged
Moving battery calculation for lipo discharge into utility.c#227Sapd merged 3 commits intoSapd:masterfrom
Sapd merged 3 commits intoSapd:masterfrom
Conversation
Owner
|
Thank you, its a good PR for cleaning up. However we should also provide a function for simple splines. As polynomials are a bit of overkill (and more complicated) for most cases, i.e.: We maybe should also start writing tests for utility functions. |
rpbaptist
pushed a commit
to rpbaptist/HeadsetControl
that referenced
this pull request
May 31, 2024
* Move calculation of battery level for discharging battery to utility function * Refactored battery calculation to use the 'utility function'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have moved the calculation of the battery level over to
utility.cand updated the code for the Logitech Pro X to use it. I did not touch thelogitech_g633_g933_935.cas I cannot verify the correctness, when porting it.