initial support for hyperx cloud flight wireless#211
Merged
Sapd merged 23 commits intoSapd:masterfrom May 24, 2022
Merged
Conversation
Contributor
Author
|
fixed some problems with the code style... try again... |
Contributor
Author
|
format-check fails were valid, but I do not see the point for the last whitespace failures as there are no longer any trailing whitespaces? |
Owner
|
Thank you. Yeah there seems to be some problem at the CI whitespace check. Probably it does not check between the whole diff but some of the last commits. |
Contributor
Author
|
Thank you for inclusion. Yes, the whitespace check seems to check those also for all intermediate patches. It seems without some kind of a rebase / squashing of those patches these kind of errors won't go away. Well, good to have a human reviewer here which can overrule automatic checks - seems way easier than the rebase/squash thing. ;-) |
rpbaptist
pushed a commit
to rpbaptist/HeadsetControl
that referenced
this pull request
May 31, 2024
Co-authored-by: michael <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial support for hyperx cloud flight wireless
There are several revisions of this headset but I do only have one. Maybe other revisions need further work but I didn't get any review on my fork.