fix(core): Correct DbgHelp.h capitalisation for MinGW cross-compilation#1813
Merged
SanderMertens merged 1 commit intoSep 28, 2025
Merged
fix(core): Correct DbgHelp.h capitalisation for MinGW cross-compilation#1813SanderMertens merged 1 commit into
SanderMertens merged 1 commit into
Conversation
Owner
|
LGTM! Can you also update distr/flecs.c with the change? That will fix the CI failure. |
When cross-compiling on a case-sensitive filesystem (like Linux), the build fails because the MinGW packages for major distributions provide the Windows 'dbghelp' headers and libraries in all-lowercase. This change corrects the casing in two places to align with this standard: 1. The #include in src/os_api.c is changed to <dbghelp.h>. 2. The target_link_libraries() call in CMakeLists.txt is changed to link against 'dbghelp'. This resolves both the compilation and subsequent linking errors. Closes #1813
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the include to use lowercase, which matches the de facto standard for MinGW header packaging on all major Linux distributions (Fedora, Debian, Arch). This resolves a case-sensitivity build failure when cross-compiling.
Closes #1812