Properly set and read is_ref in delegate.hpp to fix non-$this variable source components in query iteration#1327
Merged
SanderMertens merged 3 commits intoSep 1, 2024
Conversation
…e source components in query iteration - set is_ref in populate_self so that it's properly set for any type of query - always set row to 0 for components with is_ref to avoid indexing garbage Fixes SanderMertens#1324
Owner
|
Nice! Can you:
|
Contributor
Author
|
I tried to cover some range of scenarios in the test. Didn't add optional arguments because I felt like the test was getting a bit long. |
Owner
|
Thanks, almost there:
|
Contributor
Author
|
I thought about is some more and I'm pretty sure these 2 tests cover all cases. I wanted to make sure reading / writing relationships was consistent originally, but I'm pretty sure that superfluous. |
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1324