Skip to content

DeepScanners refactoring - #994

Merged
babenek merged 1 commit into
Samsung:mainfrom
babenek:main
Oct 23, 2026
Merged

babenek merged 1 commit into
Samsung:mainfrom
babenek:main

Conversation

@babenek

@babenek babenek commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which is fixed.

  • Add TextScanner instead ByteScanner for deep scan (reduce extra text decoding)
  • Extract to separated scanners YamlScanner & Lang scanner
  • add shelf attribute for deep scanner to identify whether a scan is possible with depth=0
  • improve fallback scanner workflow

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.83886% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.63%. Comparing base (b4875ca) to head (e8863e2).

Files with missing lines Patch % Lines
credsweeper/deep_scanner/xml_scanner.py 89.58% 4 Missing and 1 partial ⚠️
credsweeper/file_handler/data_content_provider.py 70.00% 1 Missing and 2 partials ⚠️
credsweeper/deep_scanner/yaml_scanner.py 93.33% 2 Missing ⚠️
credsweeper/deep_scanner/deep_scanner.py 96.55% 0 Missing and 1 partial ⚠️
credsweeper/deep_scanner/text_scanner.py 93.75% 1 Missing ⚠️
credsweeper/file_handler/byte_content_provider.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   90.65%   90.63%   -0.02%     
==========================================
  Files         169      170       +1     
  Lines        7307     7318      +11     
  Branches     1225     1199      -26     
==========================================
+ Hits         6624     6633       +9     
+ Misses        461      460       -1     
- Partials      222      225       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babenek
babenek marked this pull request as ready for review October 22, 2026 14:01
@babenek
babenek requested a review from a team as a code owner October 22, 2026 14:01
@babenek
babenek merged commit d0ed1ed into Samsung:main Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants