Skip to content

Quick fix - #992

Merged
babenek merged 5 commits into
mainfrom
quick_fix
Oct 20, 2026
Merged

Quick fix#992
babenek merged 5 commits into
mainfrom
quick_fix

Conversation

@Pomidorry

@Pomidorry Pomidorry commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Description

  1. Pass --confidence from CLI to CredSweeper: the option was parsed but
    never used, so all rules were always applied (default "weak")
  2. main(["--banner"]) returned 1 when called from code: the check used
    sys.argv instead of the argv passed to main()
    E. g.
 python -c "from credsweeper.main import main; print('result:', main(['--banner']))"
CredSweeper 1.19.4 crc32:c0b4642b
2026-10-20 15:31:05,799 | ERROR | MainProcess:MainThread | main.py:268 | Not specified 'path' or 'diff_path'
result: 1
  1. Remove debug log "match" in CPIO detection

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@Pomidorry
Pomidorry requested a review from a team as a code owner October 20, 2026 12:43
@codecov-commenter

codecov-commenter commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.63%. Comparing base (bb0822d) to head (eb23df7).

Files with missing lines Patch % Lines
credsweeper/main.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   90.59%   90.63%   +0.04%     
==========================================
  Files         169      169              
  Lines        7306     7307       +1     
  Branches     1224     1225       +1     
==========================================
+ Hits         6619     6623       +4     
+ Misses        464      462       -2     
+ Partials      223      222       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

babenek
babenek approved these changes Oct 20, 2026
View reviewed changes

@babenek babenek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@babenek
babenek merged commit 135a9dc into main Oct 20, 2026
@babenek
babenek deleted the quick_fix branch October 20, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@babenek babenek babenek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pomidorry @codecov-commenter @babenek