Repository navigation
Keep changes of all diffs for the same file in a patch - #991
Merged
Merged
Conversation
Signed-off-by: Sebastian Turner <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
- Coverage 90.61% 90.58% -0.03%
==========================================
Files 169 169
Lines 7306 7306
Branches 1224 1224
==========================================
- Hits 6620 6618 -2
Misses 464 464
- Partials 222 224 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
babenek
approved these changes
Oct 20, 2026
babenek
left a comment
babenek
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks @auraseb for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DiffContentProvider.patch2files_diffassigned the changes of each diff to its path, so when a patch contains several diffs of the same file (git format-patch --stdout,git log -p), only the last one was kept and the earlier added or deleted lines were never scanned.How has this been tested?
pytest tests --ignore=tests/test_app.py: 1198 passed, 1 skipped.pytest tests/test_app.py: 54 passed. The new test fails on main and passes with the fix. The benchmark scans files with--path, so its scores are not affected.Fixes #990