@W-22850150 ci: drop Node 26 from the Windows test matrix#505
Merged
Conversation
Node 26 on Windows aborts with `Assertion failed: !_wcsnicmp(filename, dir, dirlen)` in src/win/fs-event.c during chokidar's recursive watch tests. This is the same libuv bug that pinned Windows Node 24 to 24.15.0 — but it lives in libuv 1.52.1, which ships in *every* Node 26.x release, so there is no 26.x version to pin to. The failure is environmental (Node/libuv/chokidar on Windows), unrelated to the mocha 11 / tsx / yargs work in #499; the Linux matrix runs Node 26 green. Drop 26.x from the Windows matrix and document why; add it back once upstream libuv ships a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #499. Removes
26.xfrom the Windows CI matrix only — Node 26 stays on the Linux matrix (where it's fully green) and in the dev/CLI toolchain.Why
After #499 merged, the
test-windows (26.x)job failed with:This is a libuv/chokidar bug, not a regression from the mocha 11 / tsx / yargs work:
24.15.0(see the existing matrix comment).chokidar's recursive watch tests (src/operations/code/watch.ts), is Windows-only, and aborts the process before tests finish (exit 255, 0% coverage).The
test-windowsjob iscontinue-on-error: true(advisory), so this never blocked merges — but leaving a permanent red X is misleading. Dropping 26.x from the Windows matrix (with a comment explaining why) keeps CI signal honest. Add it back once upstream libuv ships a fix.Change
.github/workflows/ci.yml: Windows matrix[22.x, 24.15.0, 26.x]→[22.x, 24.15.0], with an updated comment. Linux matrix unchanged ([22.x, 24.x, 26.x]).