feat: when using from table to time series feature must be given#572
Merged
lars-reimann merged 21 commits intomainfrom Mar 18, 2024
Merged
Conversation
this is not finished
Fixed 82 Errors
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2956 2973 +17
=========================================
+ Hits 2956 2973 +17 ☔ View full report in Codecov by Sentry. |
Gerhardsa0
changed the title
Gerhardsa0
changed the title
- added tests for properties
…_time_series-feature-must-be-given' into 571-bug-when-using-from_table_to_time_series-feature-must-be-given
This reverts commit f359698.
tests/safeds/data/tabular/containers/_table/_time_series/__init__.py
Outdated
Show resolved
Hide resolved
lars-reimann
requested changes
Mar 18, 2024
Member
|
@Gerhardsa0 Please remove the merge conflict, then this should be good to go. |
Contributor
Author
yes, thank you! |
…g-when-using-from_table_to_time_series-feature-must-be-given # Conflicts: # tests/safeds/data/tabular/containers/_table/_tagged_table/_time_series/test_sizeof.py # tests/safeds/data/tabular/containers/_time_series/test_eq.py # tests/safeds/data/tabular/containers/_time_series/test_hash.py
lars-reimann
deleted the
571-bug-when-using-from_table_to_time_series-feature-must-be-given
branch
WinPlay02
reviewed
Mar 18, 2024
Contributor
WinPlay02
left a comment
WinPlay02
left a comment
There was a problem hiding this comment.
Everything looks good 👍🏻
lars-reimann
pushed a commit
that referenced
this pull request
Apr 3, 2024
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03) ### Features * add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7)) * add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522) * add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee)) * added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519) * added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549) * when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571) ### Bug Fixes * incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53)) * mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
Member
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #571
Summary of Changes
TimeSeries no longer is subclass of TaggedTable only of Table