feat: Add find_edges method in Image#531
Merged
lars-reimann merged 13 commits intomainfrom Jan 21, 2024
Merged
Conversation
…e the find_edges method from the old Image class with pillow fix: Fixed images with one channel for both repr and both to_file methods test: Added grayscale images that only contain one channel each
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 2687 2706 +19
=========================================
+ Hits 2687 2706 +19 ☔ View full report in Codecov by Sentry. |
…t 3 or 4 channel prior" This reverts commit e0dc5ed.
… channel prior tests: Added test cases to TestToJpegFile::test_should_save_file & changed test to not compare content of the images
…cale image docs: Reenabled Image.adjust_color_balance & Image.find_edges in the Image tutorial
…om/Safe-DS/Stdlib into 523-add-find_edges-method-in-image
lars-reimann
approved these changes
Jan 21, 2024
lars-reimann
pushed a commit
that referenced
this pull request
Feb 3, 2024
## [0.18.0](v0.17.1...v0.18.0) (2024-02-03) ### Features * Add adjust_color_balance method in Image ([#530](#530)) ([dba23f9](dba23f9)), closes [#525](#525) * Add find_edges method in Image ([#531](#531)) ([d728eb6](d728eb6)), closes [#523](#523) * class for time series ([#508](#508)) ([73cdfb1](73cdfb1)), closes [#481](#481)
Member
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #523
Summary of Changes
Added find_edges method for the new image class. Works just like the find_edges method from the old Image class with pillow.
Fixed images with one channel for both repr and both to_file methods.
Added grayscale images that only contain one channel each.
Re-enabled Image.adjust_color_balance & Image.find_edges in the Image tutorial.
Added warning for adjust_color_balance if it is used on a grayscale image.