Merged
Conversation
added 4 commits
December 5, 2023 19:19
time series class is a tagged table which treats the target column as an feature and adds an time column, which a neither a feature or target column
also I added alot of tests, I am done until the test_from_table and also time series functionalities needs to be added, this can take some time still(the testing takes alot of time)
- added time series blue print and extended errors and tests - not having a great week, rthats
removed the tests for the new features and they are just there for blue print
Gerhardsa0
changed the title
added 2 commits
December 14, 2023 17:50
…meseries-class-in-safe-ds-std-lib-1 # Conflicts: # poetry.lock
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
lars-reimann
changed the title
Member
|
I'm not going to fully review this until the automated checks pass. Do you need some specific feedback? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 49 50 +1
Lines 2706 2831 +125
==========================================
+ Hits 2706 2831 +125 ☔ View full report in Codecov by Sentry. |
added 5 commits
December 19, 2023 15:23
…ted that I also dont know how I will handle the _from_table function
sibre28
previously approved these changes
Jan 22, 2024
Marsmaennchen221
requested changes
Jan 22, 2024
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
fixed from_table_to_time_series function and updated the test
…std-lib-1' into 481-timeseries-class-in-safe-ds-std-lib-1
Marsmaennchen221
requested changes
Jan 29, 2024
Co-authored-by: Alexander <[email protected]>
Marsmaennchen221
approved these changes
Jan 29, 2024
lars-reimann
pushed a commit
that referenced
this pull request
Feb 3, 2024
## [0.18.0](v0.17.1...v0.18.0) (2024-02-03) ### Features * Add adjust_color_balance method in Image ([#530](#530)) ([dba23f9](dba23f9)), closes [#525](#525) * Add find_edges method in Image ([#531](#531)) ([d728eb6](d728eb6)), closes [#523](#523) * class for time series ([#508](#508)) ([73cdfb1](73cdfb1)), closes [#481](#481)
Member
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481
Summary of Changes
added the time series class, with all basic tests and functionalities
the new features are not added, but this would make the pr too big