feat: change image class to use PyTorch tensors and methods#506
Merged
lars-reimann merged 34 commits intomainfrom Jan 10, 2024
Merged
Conversation
feat: Added test implementation of CNN Layers
…o_pytorch_tensor_and_cnn_layer # Conflicts: # poetry.lock # pyproject.toml # tests/safeds/data/image/containers/test_image.py # tests/safeds/data/tabular/containers/_column/test_plot_boxplot.py # tests/safeds/data/tabular/containers/_column/test_plot_histogram.py # tests/safeds/data/tabular/containers/_table/test_plot_boxplots.py # tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py # tests/safeds/data/tabular/containers/_table/test_plot_histograms.py # tests/safeds/data/tabular/containers/_table/test_plot_lineplot.py # tests/safeds/data/tabular/containers/_table/test_plot_scatterplot.py
… uses cpu docs: Added docstrings to all Image methods feat: Added IllegalFormatError refactor: Removed ImagePil
…ethods' of https://github.com/Safe-DS/Stdlib into image_to_pytorch_tensor_and_cnn_layer # Conflicts: # poetry.lock
refactor: Completely removed ImagePil
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
…ethods' of https://github.com/Safe-DS/Stdlib into 505-change-image-class-to-use-pytorch-tensors-pytorch-methods
refactor: Removed IllegalFormatError; Image._repr_jpeg now returns None if image has alpha channel
feat: Added IllegalFormatError
lars-reimann
changed the title
…nge-image-class-to-use-pytorch-tensors-pytorch-methods # Conflicts: # poetry.lock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 2699 2681 -18
=========================================
- Hits 2699 2681 -18 ☔ View full report in Codecov by Sentry. |
test: added missing match arguments to tests with pytest.raises
…ethods' of https://github.com/Safe-DS/Stdlib into 505-change-image-class-to-use-pytorch-tensors-pytorch-methods
style: added section dividers in Image
lars-reimann
requested changes
Jan 9, 2024
Member
lars-reimann
left a comment
lars-reimann
left a comment
There was a problem hiding this comment.
Looks really comprehensive. I only have a few remarks, mostly regarding the handling of devices.
lars-reimann
deleted the
505-change-image-class-to-use-pytorch-tensors-pytorch-methods
branch
Member
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505
Summary of Changes
feat: Changed Image class to use PyTorch tensors
refactor: Image class now uses PyTorch transform methods