Skip to content

Comments

fix: language server crash on startup#947

Merged
lars-reimann merged 2 commits intomainfrom
945-language-server-crash-when-starting-extension
Mar 7, 2024
Merged

fix: language server crash on startup#947
lars-reimann merged 2 commits intomainfrom
945-language-server-crash-when-starting-extension

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Mar 7, 2024

Closes #945

Summary of Changes

Add a missing await to fix a crash when starting the language server.

@lars-reimann lars-reimann linked an issue Mar 7, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.09s
✅ TYPESCRIPT eslint 1 0 0 3.49s
✅ TYPESCRIPT prettier 1 0 0 0.64s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f8b7064) to head (e700d01).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #947   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           92        92           
  Lines        17082     17081    -1     
  Branches      3540      3540           
=========================================
- Hits         17082     17081    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review March 7, 2024 15:48
Copy link
Contributor

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm, this fixes issue #945

@lars-reimann lars-reimann merged commit 9923074 into main Mar 7, 2024
@lars-reimann lars-reimann deleted the 945-language-server-crash-when-starting-extension branch March 7, 2024 16:31
lars-reimann pushed a commit that referenced this pull request Apr 1, 2024
## [0.9.0](v0.8.0...v0.9.0) (2024-04-01)

### Features

* `unknown` default value of stub parameters ([#952](#952)) ([78103e3](78103e3)), closes [#951](#951)
* `unknown` type ([#973](#973)) ([4638249](4638249)), closes [#967](#967)
* add constraints to stubs ([#953](#953)) ([dc5bf3b](dc5bf3b))
* allow any widening/narrowing type cast ([#948](#948)) ([ce01628](ce01628))
* checking of parameter bounds ([#925](#925)) ([610604f](610604f)), closes [#18](#18)
* Markdown documentation generator ([#963](#963)) ([77d04de](77d04de)), closes [#663](#663)
* stubs for `safe-ds` library ([#950](#950)) ([155b1c0](155b1c0)), closes [#926](#926)
* VS Code command to dump diagnostics into a JSON file ([#928](#928)) ([34fa884](34fa884)), closes [#927](#927)

### Bug Fixes

* do not memoize calls containing lambdas calling segments ([#944](#944)) ([114fee6](114fee6))
* language server crash on startup ([#947](#947)) ([9923074](9923074)), closes [#945](#945)
* type checking of two union types ([#949](#949)) ([21fc485](21fc485))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

language server crash when starting extension

2 participants