Convert Installshield Executable code to use proper reader/wrapper instead of living in PortableExecutable#59
Merged
mnadareski merged 7 commits intoSabreTools:mainfrom Jan 25, 2026
Conversation
… the latter) for a non-PE reader/wrapper
mnadareski
reviewed
Jan 25, 2026
mnadareski
approved these changes
Jan 25, 2026
HeroponRikiBestest
added a commit
to HeroponRikiBestest/SabreTools.Serialization
that referenced
this pull request
Jan 27, 2026
…stead of living in PortableExecutable (SabreTools#59) * Figure out how to access OverlayAddress in wrapper or reader (ideally the latter) for a non-PE reader/wrapper * Code works * Remove TODOs * First round of fixes. * use constants * remove comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly PRing this since the still-unsupported kinds of ISEXEs are more complicated, and will likely need or at least heavily benefit from a proper reader/wrapper. Let me know if this isn't acceptable, as I'm not sure how safe or ST-standard-following my usage of offsets are here.