Fix mszip relying on exceptions#52
Conversation
|
After the latest push, it peaks at ~5gb on the installer in |
|
Main thing still missing is that memory isn't being cleared properly, each block of compressedData still seems to be in memory? I'll need help with this, though. |
HeroponRikiBestest
changed the title
|
Disregard the above message. Better memory usage will come in a different PR. |
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
|
I mentioned it in discord earlier, but just so it's mentioned here too- please don't merge this PR until I confirm that I've done proper bulk testing of the additional suggested fixes, which likely won't happen for at least a few days. |
2 participants
Fixes #44 with some major changes. I don't know enough about mszip to know if this is 100% safe. I also assume you'd want me to make some changes on this.
This PR also drastically reduces the amount of memory needed to perform extraction, which is still a significant issue for mszip extraction.
The memory usage is still somewhat large, but I'm unsure how to properly clear memory beyond hoping C#/dotnet does it for me. If you can provide some input there, memory usage should be able to finally be reduced to a normal size.