Parse XboxOne/SX Title IDs#897
Merged
mnadareski merged 4 commits intoSabreTools:masterfrom Oct 13, 2025
Deterous:master
Merged
Conversation
mnadareski
reviewed
Oct 13, 2025
Comment on lines
+784
to
+789
| if (catalog == null) | ||
| return null; | ||
| if (!string.IsNullOrEmpty(catalog.TitleID)) | ||
| return catalog.TitleID; | ||
| if (catalog.Packages == null) | ||
| return null; |
Collaborator
There was a problem hiding this comment.
Minor cosmetic tweak
Suggested change
| if (catalog == null) | |
| return null; | |
| if (!string.IsNullOrEmpty(catalog.TitleID)) | |
| return catalog.TitleID; | |
| if (catalog.Packages == null) | |
| return null; | |
| if (!string.IsNullOrEmpty(catalog?.TitleID)) | |
| return catalog.TitleID; | |
| if (catalog?.Packages == null) | |
| return null; |
Member
Author
There was a problem hiding this comment.
Seems like you already merged but feel free to change this
mnadareski
reviewed
Oct 13, 2025
| int i = 0; | ||
| foreach (var package in catalog.Packages) | ||
| { | ||
| if (package != null && package.TitleID != null) |
Member
Author
There was a problem hiding this comment.
I could create a catalog.js where that is the case, so I thought why not do the check in MPF just in case
mnadareski
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires RedumpLib bump SabreTools/SabreTools.RedumpLib#12