fix: in-app notification banner placement#9
Closed
Just-Insane wants to merge 3 commits intodevfrom
Closed
Conversation
added 3 commits
March 8, 2026 14:37
- render NotificationBanner in ClientLayout so it spans the full viewport as position:fixed and doesn't displace page content - remove the old banner render from Room.tsx
Completes the placement move — banner is now rendered only in ClientLayout as position:fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the in-app notification banner placement so it renders in the correct position within the client layout.
Changes
NotificationBannerout ofClientNonUIFeaturesand into the correct component tree so it renders properly