fix(pwa): re-enable Workbox precaching (remove injectionPoint override)#611
Merged
7w1 merged 3 commits intoSableClient:devfrom Apr 16, 2026
Merged
fix(pwa): re-enable Workbox precaching (remove injectionPoint override)#6117w1 merged 3 commits intoSableClient:devfrom
7w1 merged 3 commits intoSableClient:devfrom
Conversation
Just-Insane
force-pushed
the
fix/workbox-precaching
branch
from
e0162bd to
58176a6
Compare
7w1
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Restores Workbox InjectManifest precaching so the PWA service worker correctly receives and routes the __WB_MANIFEST, fixing cold-start/offline behavior regressions introduced by disabling manifest injection.
Changes:
- Remove the extra
self.__WB_MANIFESTreference insrc/sw.tsby dropping theifguard, leaving a single injection point. - Remove the
injectionPoint: undefinedoverride invite.config.tsso Workbox injects the precache manifest again. - Add a changeset documenting the precaching fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
vite.config.ts |
Re-enables Workbox manifest injection (and adjusts precache options). |
src/sw.ts |
Ensures exactly one self.__WB_MANIFEST reference for Workbox InjectManifest. |
.changeset/workbox-precaching.md |
Adds release note entry for the precaching fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+179
to
+183
| // element-call is a self-contained embedded app; exclude its large assets | ||
| // from the SW precache manifest (they are not part of the Sable shell). | ||
| globIgnores: ['public/element-call/**'], | ||
| // The app's own crypto WASM and main bundle exceed the 2 MiB default. | ||
| maximumFileSizeToCacheInBytes: 10 * 1024 * 1024, // 10 MiB |
7w1
approved these changes
Apr 16, 2026
ProfessorVarox
pushed a commit
to ProfessorVarox/sable
that referenced
this pull request
May 5, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Add background styling to user profile cards ([SableClient#712](SableClient#712) by @nushea) * Add preventing url preview cards by surrounding a link in anglebrackets like <https://app.sable.moe> ([SableClient#717](SableClient#717) by @nushea) * Reorganize Embed settings and reintroduce multiple embeds ([SableClient#667](SableClient#667) by @nushea) * Change Misc. data styling in users profile pages ([SableClient#663](SableClient#663) by @nushea) * add initial support for sending discoverable emojis and sticker ([SableClient#730](SableClient#730) by @dozro) ### Themes and tweaks from the catalog ([SableClient#633](SableClient#633) by @7w1) Themes are pulled from [a repo](https://github.com/SableClient/themes) now, so you get the full power of CSS instead of a palette. Tweaks are new: CSS overlays that sit on top of whatever theme you are using. You'll be prompted to migrate to the new system whenever you update, if you choose not to, you'll be limited to the basic dark/light themes. A few additional themes have been added (Rose Pine variantes, Catpuccin) along with some basic tweaks (circular avatars, monochrome avatars, and square stuff). You can share themes and tweaks. For themes uploaded online, simply hit the copy button in settings and paste the link in chat. If the setting is enabled, a preview will be generated. Third party themes (as defined by the config.json) have prominent warning banners and fetching is disabled by default. You can also export and share theme files directly, although no previews are generated for these. If you're intrested in getting a theme or tweak added to the official catalog, contribute to the themes repo linked above! We're eager to add more! ### Markdown parser and render updates ([SableClient#727](SableClient#727) by @7w1) Migrated markdown parsing and rendering to use marked, which should fix most (all?) markdown issues involving lists/nested structures, inconsistent/inaccurate code blocks, escape sequences, and all the other bugs with literally everything. Added math rendering support via marked and KaTeX, uses standard `$$` and `$` delimiters. Only renders a subset of latex tags that will likely need to be expanded so feel free to make issues if needed. Also adds support for sending markdown tables (although they're rendered rather plainly at the moment), sending valid html directly (such as for colored text), and properly escaping anything with backslashes. Fixes link previews appearing in code blocks, fixes pmp new line behavior, fixes links not opening in new tabs, and fixes editing arbitrary html messages, probably. Finally, the old WYSIWYG editor has been completely removed. ## Fixes * Fix spam-clicking abbreviations crashing sable ([SableClient#665](SableClient#665) by @nushea) * Add cache-control headers in Caddyfile for assets, service worker, and index.html ([SableClient#609](SableClient#609) by @Just-Insane) * Fix the first pin event in a room looking empty ([SableClient#685](SableClient#685) by @nushea) * Fix read receipt scrolling not working ([SableClient#631](SableClient#631) by @Septicity) * Fix status sometimes sticking in member tile ([SableClient#664](SableClient#664) by @nushea) * Fix apng files not animating. ([SableClient#737](SableClient#737) by @7w1) * Some fixes to sync requests being spammed on loading screen and for multi-account background syncing, it should also load faster now! ([SableClient#736](SableClient#736) by @7w1) * Fix other dmed party not being added as a founder by default when creating a dm. ([SableClient#737](SableClient#737) by @7w1) * Update verbiage in the credits ([SableClient#728](SableClient#728) by @nushea) * spoilered text now gets replaced with `[Spoiler]` in the plain text fallback, as per MSC4454 ([SableClient#715](SableClient#715) by @dozro) * Hide copied settings links on dynamic rows ([SableClient#695](SableClient#695) by @hazre) * Fix button hover background smearing in virtual list rows by suppressing transform on hover ([SableClient#614](SableClient#614) by @Just-Insane) * Fix Workbox precaching by removing injectionPoint override that was silently disabling all precache entries ([SableClient#611](SableClient#611) by @Just-Insane) ### Change how settings links are shared ([SableClient#695](SableClient#695) by @hazre) Settings links copied from Sable now stay on the current client URL and include a small Sable marker in the link. That lets Sable recognize settings links copied from other Sable instances without treating unrelated third-party `/settings/...` links as Sable settings links. When you send a bare settings link in the composer, Sable now rewrites it into a labeled link so it looks better on non-Sable clients too. For example: `[Settings > Account > Display Name](https://client.example/settings/account?focus=display-name&moe.sable.client.action=settings)`. Invalid or malformed settings-looking links now stay normal links instead of being shown as settings chips. If you previously set `settingsLinkBaseUrl` in `config.json`, remove it. Sable now derives settings links from the runtime app URL, and the old config key is no longer used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
injectionPoint: undefinedwas set invite.config.tsto silence a WorkboxAssertionErrorabout multipleself.__WB_MANIFESToccurrences (anifguard insw.tsplus theprecacheAndRoute()call = two matches; Workbox requires exactly one). The unintended consequence: Workbox never injected the precache manifest, so no assets were precached — every cold start hit the network instead of serving from cache, and offline use was broken entirely.Fix: remove the
ifguard insw.ts(leaving exactly oneself.__WB_MANIFESTreference) then removeinjectionPoint: undefinedfromvite.config.tsto restore normal precaching behaviour.Fixes #
Type of change
Checklist:
AI disclosure:
The root cause diagnosis (two
self.__WB_MANIFESTreferences causing Workbox to silently skip injection) was identified with AI assistance. I verified the fix by checking Workbox'sinjectionPointbehaviour and confirming precaching was restored.