Skip to content

Commit 70fade9

Browse files
committed
fix standard embeds not rendering
1 parent 690058f commit 70fade9

3 files changed

Lines changed: 13 additions & 4 deletions

File tree

.changeset/fix-embed-render.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
default: patch
3+
---
4+
5+
Fix standard embed links not rendering.

src/app/components/RenderMessageContent.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
UnsupportedContent,
2828
VideoContent,
2929
} from './message';
30-
import { UrlPreviewCard, UrlPreviewHolder, ClientPreview } from './url-preview';
30+
import { UrlPreviewCard, UrlPreviewHolder, ClientPreview, youtubeUrl } from './url-preview';
3131
import { Image, MediaControl, PersistedVolumeVideo } from './media';
3232
import { ImageViewer } from './image-viewer';
3333
import { PdfViewer } from './Pdf-viewer';
@@ -118,15 +118,18 @@ function RenderMessageContentInternal({
118118
if (type) {
119119
return <UrlPreviewCard key={url} url={url} ts={ts} mediaType={type} />;
120120
}
121-
if (clientUrlPreview) {
121+
if (clientUrlPreview && youtubeUrl(url)) {
122122
return <ClientPreview url={url} />;
123123
}
124+
if (urlPreview) {
125+
return <UrlPreviewCard key={url} url={url} ts={ts} mediaType={type} />;
126+
}
124127
return null;
125128
})}
126129
</UrlPreviewHolder>
127130
);
128131
},
129-
[ts, clientUrlPreview]
132+
[ts, clientUrlPreview, urlPreview]
130133
);
131134

132135
const renderCaption = () => {

src/app/components/url-preview/ClientPreview.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ export const YoutubeElement = as<'div', YoutubeElementProps>(({ videoId, embedDa
140140
);
141141
});
142142

143-
const youtubeUrl = (url: string) => url.match(/(https:\/\/)(www\.|m\.|)(youtube\.com|youtu\.be)\//);
143+
export const youtubeUrl = (url: string) =>
144+
url.match(/(https:\/\/)(www\.|m\.|)(youtube\.com|youtu\.be)\//);
144145

145146
export const ClientPreview = as<'div', { url: string }>(({ url, ...props }, ref) => {
146147
const [showYoutube] = useSetting(settingsAtom, 'clientPreviewYoutube');

0 commit comments

Comments
 (0)