Updated example & README to reflect build system changes #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in pull request #1703, this pull request updates the example to use the updated build system properly.
Note: the GitHub workflow currently fails, but this is due to the SVF NPM package not actually installing the CMake package at all. Instead, the NPM package runs
build.shwhich only builds SVF:As discussed in pull request #1703 however, using the CMake package inside of the build tree could lead to invalid paths and unexpected behaviour and should not be supported, so with that pull request, this example's workflow still fails.
This could be fixed easily by updating
build.shto actually install the SVF package (by addingcmake --install [Release|Debug]-buildand adding--install-prefix=<prefix>to the configuration step (or--prefix=<prefix>to thecmake --install ...command)). The default installation prefix (/usr/local) requires root permissions however, so perhaps an alternative prefix should be used by default, though unless the prefix$SVF_DIRis used, this could require some modifications to ensure the environment uses the non-standard installation prefix.Ideally, I think it'd be much better for maintainability and clarity to move the part of
build.shthat pulls, builds, and installs LLVM and Z3 to a separate script (e.g.,get_llvm.shandget_z3.sh). Then, thebuild.shandsetup.shscripts could be removed entirely, and the build & installation instructions (on the Wiki) could simply show the standard installation instructions (similar to the README of this example).