Enhanced IPA Role with HBAC Support and Unified IPA Search Helper#190
Merged
Conversation
madhuriupadhye
force-pushed
the
hbac
branch
2 times, most recently
from
June 30, 2025 16:39
b43f211 to
c17b4ff
Compare
danlavu
requested changes
Jun 30, 2025
madhuriupadhye
force-pushed
the
hbac
branch
2 times, most recently
from
July 4, 2025 14:51
c888a3f to
2989749
Compare
Contributor
|
Please fix flake8 issues: |
danlavu
reviewed
Jul 10, 2025
danlavu
left a comment
Contributor
There was a problem hiding this comment.
Is this still a cursory review? If it is, everything looks good, I just have a question about why info method output. If not, I need a little more time to review it.
madhuriupadhye
force-pushed
the
hbac
branch
2 times, most recently
from
July 10, 2025 12:13
04fddea to
6eba8a9
Compare
madhuriupadhye
force-pushed
the
hbac
branch
2 times, most recently
from
July 14, 2025 14:14
31ab596 to
690a3af
Compare
madhuriupadhye
marked this pull request as draft
September 11, 2025 14:57
madhuriupadhye
force-pushed
the
hbac
branch
4 times, most recently
from
September 30, 2025 11:33
1ea50ce to
67f6c80
Compare
madhuriupadhye
force-pushed
the
hbac
branch
2 times, most recently
from
September 30, 2025 15:12
9082329 to
6fde099
Compare
madhuriupadhye
marked this pull request as ready for review
September 30, 2025 15:15
danlavu
reviewed
Oct 2, 2025
danlavu
left a comment
Contributor
There was a problem hiding this comment.
Other than the docstring fixes, it looks great, thank you.
justin-stephenson
previously approved these changes
Oct 6, 2025
justin-stephenson
left a comment
Contributor
There was a problem hiding this comment.
Ack, LGTM. Thank you.
danlavu
previously approved these changes
Oct 9, 2025
danlavu
left a comment
Contributor
There was a problem hiding this comment.
One minor phrasing, otherwise it looks great, thank you!
madhuriupadhye
dismissed stale reviews from danlavu and justin-stephenson
via
October 13, 2025 09:37
2d1098e
madhuriupadhye
force-pushed
the
hbac
branch
2 times, most recently
from
October 13, 2025 13:38
2d1098e to
1ab29cf
Compare
Adds comprehensive Host-Based Access Control (HBAC) management and search capabilities to the IPA role in the SSSD test framework. Key additions: IPAHBACService: Manage HBAC services used in access control policies. IPAHBACServiceGroup: Group HBAC services for more flexible policy definitions. IPAHostGroup: Manage host groups, including retrieval and searching capabilities. IPAHBAC: Manage HBAC rules, including creation, modification, enabling/disabling, and access testing. Unified Search Helper: Introduction of the ipa_search static method inside the main IPA role class that provides: A generic IPA CLI command execution and output parsing framework. Simplifies search logic across IPA entity classes like HBACService, HBACServiceGroup, HostGroup, and HBAC. Returns consistent, flat lists of attribute values from search results. Standardizes use of the --all option and multi-block output parsing. Signed-off-by: Madhuri Upadhye <[email protected]>
justin-stephenson
approved these changes
Oct 13, 2025
danlavu
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.