Skip to content

sss pac responder client#150

Merged
pbrezina merged 3 commits into
SSSD:masterfrom
sumit-bose:sss_pac_responder_client
Oct 16, 2025
Merged

sss pac responder client#150
pbrezina merged 3 commits into
SSSD:masterfrom
sumit-bose:sss_pac_responder_client

Conversation

@sumit-bose

Copy link
Copy Markdown
Contributor

No description provided.

@sumit-bose
sumit-bose marked this pull request as draft October 7, 2025 14:00
@sumit-bose

Copy link
Copy Markdown
Contributor Author

Hi @pbrezina,

to be able to the multi-threaded clients of the PAC responder I took related code form the SSSD tree and currently build ti as part of the ci-sssd-random package which is installed (iiuc) on the IPA server the the test client. I wonder if this is ok with repect to keep the number of additional packages small, or if you prefer to have a dedicated package for this and only install it on the client?

Additionally, I wonder, since random.so is built in src/ansible/roles/passkey/tasks/main.yml as well, if putting the PAC client into the rpm package is the expected way to handle binaries at all?

Thanks.

bye,
Sumit

@pbrezina

pbrezina commented Oct 9, 2025

Copy link
Copy Markdown
Member

Hi, since this is part of the test and performs testing, I think it should be part of SSSD repository so we can change it if needed. The random.so is not used directly by tests, it is something that makes umockdev work. But in our previous discussions @jakub-vavra-cz did not want to install build dependencies when running in IdM CI to have minimal environment, so unless there is a move in this opinion, we need to put it here.

Maybe we can just remove the sssd-ci-random package and rename it to sssd-ci[-test-deps]?

src/ansible/roles/passkey/tasks/main.yml

Looking at 9486575 it looks to be used in Ubuntu and Debian, these distros were now removed so it can be removed as well.

@sumit-bose
sumit-bose force-pushed the sss_pac_responder_client branch from 48102cb to 87014e6 Compare October 10, 2025 15:50
@sumit-bose

Copy link
Copy Markdown
Contributor Author

Maybe we can just remove the sssd-ci-random package and rename it to sssd-ci[-test-deps]?

Hi,

do I understand correctly that it would be better to rename the rpm in a separate PR and wait until it is committed and a new package is build in copr before it can be used here?

bye,
Sumit

@pbrezina

Copy link
Copy Markdown
Member

Maybe we can just remove the sssd-ci-random package and rename it to sssd-ci[-test-deps]?

Hi,

do I understand correctly that it would be better to rename the rpm in a separate PR and wait until it is committed and a new package is build in copr before it can be used here?

Yes, if we want to make CI green. But the RPM is tested in "Build RPMS" job, so I do not think it is necessary.

@sumit-bose
sumit-bose marked this pull request as ready for review October 15, 2025 13:35
@sumit-bose

Copy link
Copy Markdown
Contributor Author

Maybe we can just remove the sssd-ci-random package and rename it to sssd-ci[-test-deps]?

Hi,
do I understand correctly that it would be better to rename the rpm in a separate PR and wait until it is committed and a new package is build in copr before it can be used here?

Yes, if we want to make CI green. But the RPM is tested in "Build RPMS" job, so I do not think it is necessary.

Hi,

so how to move forward, are you fine if this PR is reviewed as is or shall I split out the name change of the rpm into a different PR?

bye,
Sumit

@pbrezina

Copy link
Copy Markdown
Member

I am perfectly fine, I just waited to be ready for review. Ack.

@pbrezina
pbrezina merged commit 0a12fd4 into SSSD:master Oct 16, 2025
2 of 7 checks passed
sumit-bose added a commit to sumit-bose/sssd that referenced this pull request Oct 20, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.
sumit-bose added a commit to sumit-bose/sssd that referenced this pull request Oct 20, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.
sumit-bose added a commit to sumit-bose/sssd that referenced this pull request Nov 17, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.
sssd-bot pushed a commit to sumit-bose/sssd that referenced this pull request Nov 18, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
alexey-tikhonov pushed a commit to SSSD/sssd that referenced this pull request Nov 18, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
sssd-bot pushed a commit to sssd-bot/sssd that referenced this pull request Nov 18, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
sssd-bot pushed a commit to sssd-bot/sssd that referenced this pull request Nov 18, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
sumit-bose added a commit to sssd-bot/sssd that referenced this pull request Nov 19, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
sssd-bot pushed a commit to sssd-bot/sssd that referenced this pull request Nov 19, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
alexey-tikhonov pushed a commit to SSSD/sssd that referenced this pull request Nov 19, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
sssd-bot pushed a commit to sssd-bot/sssd that referenced this pull request Nov 19, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
(cherry picked from commit 47361fd)
sssd-bot pushed a commit to sssd-bot/sssd that referenced this pull request Nov 19, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
(cherry picked from commit 47361fd)
alexey-tikhonov pushed a commit to SSSD/sssd that referenced this pull request Nov 19, 2025
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit c78855c)
(cherry picked from commit 47361fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants