[autobackport: sssd-2-13] resolv: Fix incorrect variable used in ares_parse_txt_reply() error c…#8793
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a bug in resolv_gettxt_done where the code incorrectly checked the status variable instead of the return value ret from ares_parse_txt_reply. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…heck Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Alejandro López <[email protected]> (cherry picked from commit 4a800e5)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
d6025d8 to
fc8a802
Compare
4 participants
This is an automatic backport of PR#8791 resolv: Fix incorrect variable used in ares_parse_txt_reply() error c… to branch sssd-2-13, created by @kkzhsh.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
4a800e5 - resolv: Fix incorrect variable used in ares_parse_txt_reply() error check
Backported commits
Original Pull Request Body
In src/resolv/async_resolv.c, the error handling for ares_parse_txt_reply() checks the wrong variable. After calling ares_parse_txt_reply(), the result is stored in ret, but the code incorrectly checks status
(a previously used variable) instead.